Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruler: write meaningful logs when remote-write is disabled or is misconfigured #4141

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

dannykopping
Copy link
Contributor

What this PR does / why we need it:
This PR adds more meaningful logs when recording rules are present, but remote-write is either disabled or misconfigured.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
The previous log messages looked like this:

... msg="Rule evaluation result discarded" err=unimplemented sample="{__name__=\"test\"} => 2 @[1628673147231]"

And now look like this:

... msg="Rule evaluation result discarded" err="remote-write disabled" sample="{__name__=\"test\"} => 2 @[1628673202231]"

Checklist

  • Documentation added
  • Tests updated

@dannykopping dannykopping requested a review from a team as a code owner August 11, 2021 09:16
@owen-d owen-d merged commit ea735ab into grafana:main Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants