Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: improve LogQL section #4145

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Docs: improve LogQL section #4145

merged 3 commits into from
Aug 19, 2021

Conversation

KMiller-Grafana
Copy link
Contributor

  • Add a subsection for examples. The section will be populated with more examples over time.
  • Fix typos and wording

@KMiller-Grafana
Docs: improve LogQL section
4195711 
- Add a subsection for examples
- Fix typos and wording
sandeepsukhani
sandeepsukhani reviewed Aug 18, 2021
View reviewed changes
Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some minor nits. Other than that it LGTM!
Do you think we should have sample input/output as well for better understanding?

docs/sources/logql/query_examples.md Outdated Show resolved Hide resolved
docs/sources/logql/query_examples.md Outdated Show resolved Hide resolved
docs/sources/logql/query_examples.md
!= "grafana_com"
|~ "session opened"
!= "sudo: "
|regexp "(^(?P<user>\\S+ {1,2}){11})"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@owen-d owen-d merged commit 368d18c into grafana:main Aug 19, 2021
@KMiller-Grafana KMiller-Grafana deleted the docs/revise-LogQL branch August 19, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandeepsukhani sandeepsukhani sandeepsukhani left review comments

@owen-d owen-d owen-d approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@kavirajk kavirajk Awaiting requested review from kavirajk

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KMiller-Grafana @sandeepsukhani @owen-d