Add count to 'loki_ingester_memory_chunks' when recovery from wal #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
taisho6339
commented
Sep 5, 2021
|
|
||
| if len(s.chunks) != prevNumChunks { | ||
| memoryChunks.Add(float64(len(s.chunks) - prevNumChunks)) | ||
| } |
There was a problem hiding this comment.
This code should be executed before the failure handling because some chunks may be stored in memory even if others is failed
taisho6339
changed the title
taisho6339
force-pushed
the
fix/issue-4004
branch
from
16cc774 to
8e361af
Compare
taisho6339
force-pushed
the
fix/issue-4004
branch
from
8e361af to
92ca322
Compare
owen-d
approved these changes
Sep 28, 2021
|
|
||
| if len(s.chunks) != prevNumChunks { | ||
| memoryChunks.Add(float64(len(s.chunks) - prevNumChunks)) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
"loki_ingester_memory_chunks" isn't incremented when WAL recovery is executed so I've fixed.
Which issue(s) this PR fixes:
Fixes #4004