Loki: check new Read target when initializing boltdb-shipper store #4681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slim-bean
force-pushed
the
check-read-module
branch
from
9fe5634 to
5da29f2
Compare
|
Note: this PR also fixes an issue with the shellcheck CI after an update to shellcheck was picked up for this build. |
grafanabot
pushed a commit
that referenced
this pull request
Nov 7, 2021
…4681) * make sure to check for new `Read` target when setting up boltdb-shipper * also need to make sure ingester querier is added as a dep for Read target * improve the comment on why we shorten the cache validity. * fix shellcheck errors * apply smart defaults to chunk retain period to avoid query gaps. * typo (cherry picked from commit fbebf67)
slim-bean
added a commit
that referenced
this pull request
Nov 7, 2021
…4681) (#4689) * make sure to check for new `Read` target when setting up boltdb-shipper * also need to make sure ingester querier is added as a dep for Read target * improve the comment on why we shorten the cache validity. * fix shellcheck errors * apply smart defaults to chunk retain period to avoid query gaps. * typo (cherry picked from commit fbebf67) Co-authored-by: Ed Welch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We didn't properly register the
readandwritetarget in some of the boltdb-shipper specific registration functions, the result was not using the async_store and other code required to have consistent data access as index files are created and shipped to the store.This PR also fixes/improves the configuration of the chunk_retain_period setting, which is critical for making sure data is accessible after a chunk is flushed when using an index query cache (which boltdb-shipper does automatically using a fifo cache in the ingester component)
Which issue(s) this PR fixes:
Fixes #4680
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.