Add support for additional storage backends in operator #5432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Red-GV
force-pushed
the
operator-common-storage-config
branch
2 times, most recently
from
56e81d0 to
2b54f31
Compare
xperimental
requested changes
Feb 22, 2022
3 tasks
Red-GV
force-pushed
the
operator-common-storage-config
branch
from
2b54f31 to
cde4a57
Compare
xperimental
requested changes
Feb 23, 2022
Red-GV
force-pushed
the
operator-common-storage-config
branch
from
3fcc269 to
8311977
Compare
Red-GV
force-pushed
the
operator-common-storage-config
branch
from
8311977 to
ce42f92
Compare
xperimental
changed the title
xperimental
approved these changes
Feb 24, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds Azure, GCS, and Swift as storage options for the Loki Operator. Loki already provides support for these storage types and an easy configuration for multiple components through the
common_config. This PR implements the usage of aObjectStorageSecretTypeto allow the operator to understand what type of storage it will be utilizing. Like the existing storage configuration, the human operator would need to know what components need to be in the secret for Loki to be able to access the storage.Which issue(s) this PR fixes:
Fixes #4974
Special notes for your reviewer:
Local File System was left out of this PR as it didn't make sense to have a path directory in a secret.
Checklist
CHANGELOG.mdabout the changes.