Call correct method on index store #5979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when index gateway does not implement the new API. This bug did not yield an error but only returned incorrect results because both functions `c.IndexStore.LabelNamesForMetricName` and `c.IndexStore.LabelValuesForMetricName` return `([]string, error)`. Signed-off-by: Christian Haudum <[email protected]>
kavirajk
reviewed
Apr 21, 2022
| @@ -88,7 +88,7 @@ func (c *IndexGatewayClientStore) LabelValuesForMetricName(ctx context.Context, | |||
| }) | |||
| if isUnimplementedCallError(err) { | |||
| // Handle communication with older index gateways gracefully, by falling back to the index store calls. | |||
| return c.IndexStore.LabelNamesForMetricName(ctx, userID, from, through, metricName) | |||
| return c.IndexStore.LabelValuesForMetricName(ctx, userID, from, through, metricName, labelName, matchers...) | |||
There was a problem hiding this comment.
No it is not currently, but I have #5968 prepared, that covers this aspect.
There was a problem hiding this comment.
I'll try to find a way to test this without a huge amount of boilerplate code.
simonswine
approved these changes
Apr 21, 2022
chaudum
added a commit
that referenced
this pull request
Apr 21, 2022
when index gateway does not implement the new API. This bug did not yield an error but only returned incorrect results because both functions `c.IndexStore.LabelNamesForMetricName` and `c.IndexStore.LabelValuesForMetricName` return `([]string, error)`. Signed-off-by: Christian Haudum <[email protected]>
chaudum
added a commit
that referenced
this pull request
Apr 21, 2022
when index gateway does not implement the new API. This bug did not yield an error but only returned incorrect results because both functions `c.IndexStore.LabelNamesForMetricName` and `c.IndexStore.LabelValuesForMetricName` return `([]string, error)`. Signed-off-by: Christian Haudum <[email protected]>
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
when index gateway does not implement the new API.
This bug did not yield an error but only returned incorrect results
because both functions
c.IndexStore.LabelNamesForMetricNameandc.IndexStore.LabelValuesForMetricNamereturn([]string, error).Signed-off-by: Christian Haudum [email protected]
Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist
CHANGELOG.md.docs/sources/upgrading/_index.md