Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing changelog entry for change introduced by PR 6034. #6040

Merged
merged 2 commits into from
May 2, 2022

Conversation

DylanGuedes
Copy link
Contributor

What this PR does / why we need it:
Add a missing changelog entry introduced by PR #6034.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Checklist

  • Documentation added
  • Tests updated
  • Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@DylanGuedes DylanGuedes requested a review from a team as a code owner April 27, 2022 18:02
@DylanGuedes DylanGuedes changed the title Add missing changelog entry regarding PR 6034. Add missing changelog entry for change introduced by PR 6034. Apr 27, 2022
CHANGELOG.md Outdated
@@ -1,4 +1,6 @@
## Main

* [6034](https://github.com/grafana/loki/pull/6034) **DylanGuedes**: Promtail: Fix symlink tailing behavior.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this below into the predefined sections for the different components?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. moved, WDYT?

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants