do not initialize tsdb index store when using index gateway client for queries #6305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When Loki is configured to run the index gateway client for doing
tsdb
queries, we also initializetsdb
index store instance just to satisfy theIndexStore
interface here, which is just a fallback for keeping index gateway client and store backwards compatible.This causes us to un-necessarily run an instance of
indexshipper
which would try to sync the files locally if query readiness is configured.This PR changes the code to make the
fallbackStore
forNewIndexGatewayClientStore
optional and keep itnil
when initializing it fortsdb
index store.