Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Memberlist status page on MemberlistKV module init #6322

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

JordanRushing
Copy link
Contributor

@JordanRushing JordanRushing commented Jun 6, 2022

Signed-off-by: JordanRushing [email protected]

What this PR does / why we need it:
This PR registers a new route /memberlist to support the Memberlist status page included in the dskit library that we are using on module init.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Checklist

  • Documentation added
  • Tests updated
  • Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@JordanRushing JordanRushing requested a review from cstyan June 6, 2022 22:06
@JordanRushing JordanRushing requested a review from a team as a code owner June 6, 2022 22:06
@JordanRushing JordanRushing self-assigned this Jun 6, 2022
@grafanabot
Copy link
Collaborator

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0.1%

Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, glad we're adding this! LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants