Loki: only log "executing query" once per query in the frontend #8337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the frontend and instead log from the roundtripper so we only get one executing log line per query. Signed-off-by: Edward Welch <[email protected]>
slim-bean
force-pushed
the
fix-executing-query
branch
from
d808580 to
4471335
Compare
Co-authored-by: Danny Kopping <[email protected]>
Signed-off-by: Edward Welch <[email protected]>
|
./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Edward Welch [email protected]
What this PR does / why we need it:
This is a continuation of #7469
I had to add a way to disable logging of the "executing query" line from the Engine in the query frontend because this is called for every split by time and shard created by our roundtrippers leading to many "executing query" lines for a single query which is not desired.
Added the "executing query" line to the roundtripper and it now covers: range, instant, series, and labels queries.
It should now also only log one line per query making it possible to correlate this to the "metrics.go" line for a finished query to help debug queries which don't finish because of OOM crash.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdateddocs/sources/upgrading/_index.md