feat(storage): add support for IBM cloud object storage as storage client #8826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
type/docs
tareqmamari
force-pushed
the
ibmcloud_cos_loki
branch
from
439b8a4 to
2cbe1d6
Compare
MasslessParticle
approved these changes
Mar 17, 2023
|
This looks great, thanks for contributing! Please fix the conflicts and we'll be happy to merge |
Co-authored-by: Suruthi-G-K <[email protected]>
Rebasing the code Update config and test files with new changes Update unit test for List Arrange methods belong to mockCosClient together Updated test cases to run independently Co-authored-by: tareqmamari <[email protected]>
Added code to support IAM API Key Authentication Update the conditions for api key use default auth endpoint for cos Use default auth endpoint instead of forcing to pass auth endpoint always for COS storage provider. Replace const to defaultCOSAuthEndpoint Replace DEFAULT_COS_AUTH_ENDPOINT with defaultCOSAuthEndpoint Also fixed error fmt.Errorf call needs 6 args but has 7 args Added new cases in Test_COSConfig Added unit test for IAM API Key Authentication iam api key auth test formatting These are just minor formatting changes for IAM API key authentication tests. lowercase clifags cos prefix and rename to hedgedCOS Co-authored-by: tareqmamari <[email protected]> Co-authored-by: amankrsingh2000 <[email protected]>
* Add documentation for COS as storage * Address review comments
This commit fixes few linting for both the code base related to COS storage as well as the docs updates.
tareqmamari
force-pushed
the
ibmcloud_cos_loki
branch
from
2cbe1d6 to
762eb9a
Compare
|
@MasslessParticle We have resolved the conflicts and also fixed lint errors |
JStickler
reviewed
Mar 21, 2023
This commit addresses review comments regarding the COS-related docs. Signed-off-by: Shahul <[email protected]>
tareqmamari
force-pushed
the
ibmcloud_cos_loki
branch
from
ea7ddf2 to
b1c2601
Compare
|
@JStickler we have addressed the docs related comments. |
Without this registration, default config will be picked instead. Signed-off-by: Shahul <[email protected]>
|
@JStickler @MasslessParticle since this PR has been approved, is there anything else we should do to get it merged? Thank you! |
MasslessParticle
added
release-notes
add-to-release-notes
and removed
release-notes
labels
grafanabot
added a commit
that referenced
this pull request
Sep 1, 2023
MasslessParticle
added a commit
that referenced
this pull request
Sep 1, 2023
… IBM cloud object storage as storage client (#10424) Add PR #8826 to release notes for next release --------- Co-authored-by: Travis Patterson <[email protected]>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…ort for IBM cloud object storage as storage client (grafana#10424) Add PR grafana#8826 to release notes for next release --------- Co-authored-by: Travis Patterson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add support for IBM cloud object storage as storage client
Which issue(s) this PR fixes:
Fixes NA
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdated