chore(packaging): set tag length to 7 #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relied on git approximation before, which causes problems with other parts of the automation. Because we do not need the tag to be strictly unique, but just to identify the latest version, limiting to 7 is fine. If this ever causes problems, raise the limit but make sure to update all other places as well.
slim-bean
approved these changes
Aug 15, 2019
DanCech
reviewed
Aug 15, 2019
rfratto
approved these changes
Aug 15, 2019
Co-Authored-By: Dan Cech <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relied on git approximation before, which causes problems with other parts of
the automation.
Because we do not need the tag to be strictly unique, but just to identify the
latest version, limiting to 7 is fine.
If this ever causes problems, raise the limit but make sure to update all other
places as well.