Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(format_query): Change response type to application/json #9016

Merged
merged 4 commits into from
Apr 4, 2023

Conversation

kavirajk
Copy link
Contributor

@kavirajk kavirajk commented Apr 4, 2023

What this PR does / why we need it:
Change is to be in consistent with other endpoints and also to the prometheus format_query format. https://prometheus.io/docs/prometheus/latest/querying/api/#formatting-query-expressions

Which issue(s) this PR fixes:
Fixes #NA

Special notes for your reviewer:
requested by @gwdawson.

Related: grafana/grafana#64337

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

kavirajk added 2 commits April 4, 2023 17:53
Change is to be in consistent with other endpoints and also to the prometheus `format_query` format.
https://prometheus.io/docs/prometheus/latest/querying/api/#formatting-query-expressions

Signed-off-by: Kaviraj <[email protected]>
@kavirajk kavirajk requested a review from a team as a code owner April 4, 2023 16:12
kavirajk added 2 commits April 4, 2023 18:14
Signed-off-by: Kaviraj <[email protected]>
Signed-off-by: Kaviraj <[email protected]>
@kavirajk kavirajk requested a review from JStickler as a code owner April 4, 2023 16:21
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 4, 2023
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 4, 2023
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@kavirajk kavirajk merged commit cce3d3b into main Apr 4, 2023
@kavirajk kavirajk deleted the kavirajk/logql-prettyfy-context-type-json branch April 4, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants