Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag to disable index stats cache #9177

Merged
merged 4 commits into from
Apr 19, 2023
Merged

Flag to disable index stats cache #9177

merged 4 commits into from
Apr 19, 2023

Conversation

salvacorts
Copy link
Contributor

@salvacorts salvacorts commented Apr 18, 2023 •
edited
Loading

What this PR does / why we need it:
At #8972 we started caching all index stats requests.
If the results cache gets overloaded, it can quickly take down the rest of the loki cell due to all the increased work.
This PR adds a new flag so we can easily disable caching index stats requests.

Which issue(s) this PR fixes:
This PR is a follow up for #8972

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 18, 2023
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Apr 18, 2023
@salvacorts salvacorts marked this pull request as ready for review April 18, 2023 10:51
@salvacorts salvacorts requested review from JStickler and a team as code owners April 18, 2023 10:51
JStickler
JStickler approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

MichelHollands
MichelHollands approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salvacorts salvacorts merged commit 422560b into main Apr 19, 2023
@salvacorts salvacorts deleted the salvacorts/flag-diable-stats-cache branch April 19, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelHollands MichelHollands MichelHollands approved these changes

@owen-d owen-d owen-d approved these changes

@JStickler JStickler JStickler approved these changes

Assignees
No one assigned
Labels
size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@salvacorts @JStickler @owen-d @MichelHollands