TSDB: Reintroduce 'quiet zeros' for otel start time handling #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we want to add a zero at the start-time of the series, we don't know if a sample was previously added at that timestamp. So, use a special value which has the correct behaviour when it reaches TSDB. * Fix up OTLPTranslator tests for quiet-zero NaN change Signed-off-by: Bryan Boreham <[email protected]>
"Quiet Zeros" are used to insert the starting sample for a counter. If the zero is out-of-order then we already have some data for the series, and we should have already handled the start value, so just drop the quiet zero. Signed-off-by: Bryan Boreham <[email protected]>
Signed-off-by: Jesus Vazquez <[email protected]>
jesusvazquez
force-pushed
the
jvp/reimplement-quiet-zeros
branch
3 times, most recently
from
729830f to
933f96a
Compare
Signed-off-by: Jesus Vazquez <[email protected]>
jesusvazquez
force-pushed
the
jvp/reimplement-quiet-zeros
branch
from
933f96a to
2cc121b
Compare
We need to ensure all receivers of the data can handle it, before we start sending. Signed-off-by: Bryan Boreham <[email protected]>
4 tasks
jesusvazquez
changed the title
jesusvazquez
commented
Jan 2, 2025
Signed-off-by: Jesus Vazquez <[email protected]>
jesusvazquez
force-pushed
the
jvp/reimplement-quiet-zeros
branch
from
b7bbd5b to
d8187ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to reintroduce the previously reverted feature of quiet zeros.
This PR:
5bd08e6831d90a3ad1c2c351691e28b90849153fand8630645a7b8b07c4effb08d57e8d87d49903187f