Skip to content

Commit

Permalink
Address review feedback.
Browse files Browse the repository at this point in the history
Signed-off-by: Peter Štibraný <[email protected]>
  • Loading branch information
pstibrany committed Jun 13, 2024
1 parent 8e64c0a commit 8448b2e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
* [BUGFIX] Ingester: fixed in-memory series count when replaying a corrupted WAL. #8295
* [BUGFIX] Ingester: fix context cancellation handling when a query is busy looking up series in the TSDB index and `-blocks-storage.tsdb.head-postings-for-matchers-cache*` or `-blocks-storage.tsdb.block-postings-for-matchers-cache*` are in use. #8337
* [BUGFIX] Querier: fix edge case where bucket indexes are sometimes cached forever instead of with the expected TTL. #8343
* [BUGFIX] OTLP handler: fix errors returned by OTLP handler when used via httpgrpc tunelling. #8363
* [BUGFIX] OTLP handler: fix errors returned by OTLP handler when used via httpgrpc tunneling. #8363

### Mixin

Expand Down
2 changes: 1 addition & 1 deletion pkg/distributor/push_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,6 @@ func TestOTLPPushHandlerErrorsAreReportedCorrectlyViaHttpgrpc(t *testing.T) {

srv, err := dskit_server.New(cfg)
require.NoError(t, err)
//srv.HTTP.

push := func(ctx context.Context, req *Request) error {
// Trigger conversion of incoming request to WriteRequest.
Expand All @@ -923,6 +922,7 @@ func TestOTLPPushHandlerErrorsAreReportedCorrectlyViaHttpgrpc(t *testing.T) {
require.NoError(t, err)

var wg sync.WaitGroup
wg.Add(1)
go func() { defer wg.Done(); _ = srv.Run() }()
t.Cleanup(func() {
srv.Stop()
Expand Down

0 comments on commit 8448b2e

Please sign in to comment.