Do not reuse labels, samples and histograms slices in the write request if there are more than 10x entries than the pre-allocated size #10040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st if there are more than 10x entries than the pre-allocated size Signed-off-by: Marco Pracucci <[email protected]>
Co-authored-by: Arve Knudsen <[email protected]>
Closed
4 tasks
colega
approved these changes
Nov 28, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Today we found an ingester using much more memory than others. After some investigation we discovered that the memory utilization was caused by few requests with a very large number of samples per series. These requests poised the
TimeSeriesmemory pool with very large slices.In this PR I'm proposing to add a cap to the max slice size allowed to be put back in the timeseries pool, similarly to what I did for exemplars in #7936.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.