Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQE: Add support to disable functions+aggregations by name #10384

Merged
merged 8 commits into from
Jan 14, 2025
Merged

MQE: Add support to disable functions+aggregations by name #10384

merged 8 commits into from
Jan 14, 2025

Conversation

jhesketh
Copy link
Contributor

@jhesketh jhesketh commented Jan 9, 2025 •
edited
Loading

Related to #10067

@jhesketh jhesketh requested a review from a team as a code owner January 9, 2025 05:46
@jhesketh jhesketh mentioned this pull request Jan 9, 2025
Open
@jhesketh jhesketh force-pushed the jhesketh/mqe-function-flags branch from 8646304 to 28b5513 Compare January 9, 2025 06:19
@jhesketh jhesketh requested a review from tacole02 as a code owner January 9, 2025 06:19
charleskorn
charleskorn reviewed Jan 10, 2025
View reviewed changes
pkg/streamingpromql/config.go Outdated Show resolved Hide resolved
pkg/streamingpromql/config.go Outdated Show resolved Hide resolved
pkg/streamingpromql/engine_test.go Outdated Show resolved Hide resolved
pkg/streamingpromql/operators/aggregations/common.go Outdated Show resolved Hide resolved
pkg/streamingpromql/query.go Outdated Show resolved Hide resolved
pkg/streamingpromql/query.go Outdated Show resolved Hide resolved
pkg/streamingpromql/query.go Show resolved Hide resolved
tacole02
tacole02 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@tacole02 tacole02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I removed a few instances of "will", as we try to avoid future tense in docs.

docs/sources/mimir/configure/configuration-parameters/index.md Outdated Show resolved Hide resolved
docs/sources/mimir/configure/configuration-parameters/index.md Outdated Show resolved Hide resolved
charleskorn
charleskorn reviewed Jan 10, 2025
View reviewed changes
pkg/streamingpromql/engine.go Outdated Show resolved Hide resolved
pkg/streamingpromql/engine.go Outdated Show resolved Hide resolved
pkg/streamingpromql/config.go Outdated Show resolved Hide resolved
pkg/streamingpromql/operators/aggregations/common.go Outdated Show resolved Hide resolved
pkg/streamingpromql/operators/aggregations/common.go Outdated Show resolved Hide resolved
charleskorn
charleskorn reviewed Jan 12, 2025
View reviewed changes
pkg/streamingpromql/engine.go Outdated Show resolved Hide resolved
pkg/streamingpromql/engine_test.go Outdated Show resolved Hide resolved
pkg/streamingpromql/operators/aggregations/common.go Outdated Show resolved Hide resolved
pkg/streamingpromql/operators/aggregations/common.go Outdated Show resolved Hide resolved
pkg/streamingpromql/query.go Outdated Show resolved Hide resolved
charleskorn
charleskorn approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing my feedback!

@jhesketh jhesketh enabled auto-merge (squash) January 14, 2025 01:39
@jhesketh jhesketh merged commit 2250282 into grafana:main Jan 14, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacole02 tacole02 tacole02 approved these changes

@charleskorn charleskorn charleskorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhesketh @charleskorn @tacole02