Read-write mode integration test improvements #3433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
commented
Nov 11, 2022
…ion. Without this change, the test occasionally fails due to errors like "expanding series: empty ring" when querying for data, which is caused by querying before all three instances have joined the memberlist cluster.
charleskorn
force-pushed
the
read-write-mode-integration-test-improvements
branch
from
ddf7e0d to
1002806
Compare
pracucci
reviewed
Nov 11, 2022
charleskorn
added a commit
to grafana/e2e
that referenced
this pull request
Nov 14, 2022
This was referenced Nov 15, 2022
charleskorn
deleted the
read-write-mode-integration-test-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Builds on #3423.
Adds a fix for a race condition and verification of the range query response.
If the changes for the range query look good, I'll apply them to the other integration tests, as per @pracucci's suggestion in #3423 (comment).
Which issue(s) this PR fixes or relates to
#3363
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]