Read-write deployment mode: add integration test for recording rule evaluation #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
changed the title
pstibrany
reviewed
Nov 24, 2022
pracucci
reviewed
Nov 24, 2022
… remove possible race condition.
5 tasks
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
…valuation (grafana#3510) * Rename read-write mode integration test to better convey its purpose. * Extract read-write mode cluster setup to its own function. * Add a test for a recording rule in read-write deployment mode. * Incorporate PR feedback - push data before creating recording rule to remove possible race condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds an integration test for recording rule evaluation in read-write deployment mode.
I'm not 100% convinced I've found a robust method to avoid race conditions between setting up the rule, pushing data and then checking the evaluation of the rule - very open to feedback and alternative suggestions.
I will add a separate test for alertmanager in a subsequent PR.
Which issue(s) this PR fixes or relates to
#3363
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]