Alertmanager: Update alertmanager to grafana fork #4796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yuri-tceretian
added
the
dependencies
yuri-tceretian
force-pushed
the
yuri-tceretian/alertmanager-fork
branch
from
7676628 to
38f668d
Compare
|
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR updates alertmanager to use the Grafana fork https://github.com/grafana/prometheus-alertmanager instead of the original repository. This contributes to the unification of Grafana and Mimir alert managers and is a prerequisite for migrating the Alertmanager codebase to https://github.com/grafana/alerting repository.
The forked version of Alertmanager adds a feature grafana/prometheus-alertmanager#31 that updates V2 API to expose some information about integrations. This required a small refactoring of the code.
Also, it required an update in merger logic, now it returns an alert with the greatest lastNotify. Considering the fact that usually, only one Alertmanager node handles notifications, this change makes the merger prefer alerts from that instance rather than one that was updated latest (which I think is correct behavior, because that alert was used to send notifications)
NOTE: Pull requests can be reviewed by commit.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]