-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve "rollout progress" dashboard #5113
Improve "rollout progress" dashboard #5113
Conversation
The code LGTM, although I'm no expert on dashboard json. |
I'm very open to feedback / alternative suggestions here. I chose blue and green for the bars to avoid colours that suggest something is wrong (eg. red, orange or yellow), but I agree it can be difficult to read. I could try some different colours perhaps? Or split updated and healthy to separate panels, replacing the "unhealthy pods" panel?
Is this something we recommend or support? |
I kind of like the unhealthy pods panel, shows me exactly what its name suggests. Personally I don't need the extra bar for unhealthy anywhere. But again, that's just me. Maybe we should just make the change in our environment and get people's feedback.
That's a good question, I don't think we document this anywhere. |
For me, showing the percentage of unhealthy pods puts the number of unhealthy pods in context - for example, seeing that there's five unhealthy queriers doesn't tell me if that's worthy of concern or not, but seeing if 10% or 80% of all queriers are unhealthy tells me if I need to worry about it.
Are you referring to this override for columns that start with |
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
142337d
to
450f7c0
Compare
I see. I'm not sure how easy it is to see with the bars combined. Possibly you could mention the percentage of failed pods in the unhealthy PODs part. So if 0% of pods are unhealthy then the component is not shown and if 20% failed, you'd list it as:
Ah, misunderstood that override. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's try it
…equire scrolling.
The previous filter excluded workloads like query-tee, rollout-operator and continuous-test. Rather than try to keep the filter up-to-date, just show everything in the namespace.
…licas for each workload.
450f7c0
to
30186d9
Compare
What this PR does
This PR makes a number of small improvements to the "rollout progress" dashboard:
This is what the dashboard looks like after all of these changes for a test cell at Grafana Labs:
Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]