Helm: Remove graphite-web from graphite proxy configuration #5133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR removes the graphite-web component from the graphite proxy.
graphite-web is used to render queries that the native query engine cannot. However, the Helm chart configuration for graphite-web is broken so it's not been running and handling queries.
Issues:
/opt/
and/var/
directories and also changes the ownership of some/opt/
files. It was unable to start up due to the restricted policy that was applied to the pod/container.graphite
(code). This requires the graphite-web service name to be justgraphite
instead of{{ include "mimir.resourceName" (dict "ctx" . "component" "graphite-web") }}
.We could either fix these issues or remove graphite-web completely. I decided to remove graphite-web, as the majority of graphite functions and features are supported by the native GEM graphite query engine, and we're currently working on supporting the remaining few issues. Also the configuration for graphite-web has never worked since it was added to the Helm chart, so we're not removing any features. The configuration options for graphite-web are still available in GEM if any users want to use it.
Testing
I tested this manually by deploying the Helm chart locally in a Kind cluster and verifying a) the graphite-web resources had been removed, and b) all the other pods were successfully running. Also ran the
test_graphite_write_path.sh
andtest_graphite_read_path.sh
scripts, checked they worked, and also that queries that used to fallback to graphite-web were returning with the expected errors.Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]