-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm: release 4.5.0-rc.0 #5322
Helm: release 4.5.0-rc.0 #5322
Conversation
Signed-off-by: György Krajcsovits <[email protected]>
docs/sources/helm-charts/mimir-distributed/release-notes/v4.5.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only a small suggestion to add more details about graphite-web
|
||
## Important changes | ||
|
||
- **The `graphite-web` component was removed** from the graphite proxy. The `graphite-web` component had several configuration issues which meant it was failing to process requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add more details from the PR that changed it. What was graphite-web responsible for and why was it removed? I think #5133 has a good description, so maybe you can just copy from there
graphite-web is used to render queries that the native query engine cannot.
the majority of graphite functions and features are supported by the native GEM graphite query engine, and we're currently working on supporting the remaining few issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, I've formatted the text and added it, going to ask @osg-grafana for a review after the fact. Merging to get the chart tested.
Signed-off-by: György Krajcsovits <[email protected]>
What this PR does
Make the 4.5.0-rc.0 release.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]