Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where "unhealthy pods" panel on "rollout progress" dashboard is too tall #5200

Merged
merged 4 commits into from
Jun 9, 2023
Merged

Fix issue where "unhealthy pods" panel on "rollout progress" dashboard is too tall #5200

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f8bff5
Fix issue where "unhealthy pods" panel on "rollout progress" dashboar…
charleskorn Jun 8, 2023
63f7503
Add changelog entry.
charleskorn Jun 8, 2023
2ff354c
Regenerate files.
charleskorn Jun 8, 2023
1f2be55
Update CHANGELOG.md
charleskorn Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* [ENHANCEMENT] Dashboards: adjust layout of "rollout progress" dashboard panels so that the "rollout progress" panel doesn't require scrolling. #5113
* [ENHANCEMENT] Dashboards: show container name first in "pods count per version" panel on "rollout progress" dashboard. #5113
* [BUGFIX] Dashboards: fix "unhealthy pods" panel on "rollout progress" dashboard showing only a number rather than the name of the workload and the number of unhealthy pods if only one workload has unhealthy pods. #5113
* [BUGFIX] Dashboards: fix "unhealthy pods" panel on "rollout progress" dashboard extending below the bottom of other dashboard panels. #5200

### Jsonnet

Expand Down
2 changes: 1 addition & 1 deletion ...oring-values-generated/mimir-distributed/templates/metamonitoring/grafana-dashboards.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28783,7 +28783,7 @@ data:
},
"fill": 1,
"gridPos": {
"h": 5,
"h": 3,
"w": 10,
"x": 0,
"y": 13
Expand Down
2 changes: 1 addition & 1 deletion operations/mimir-mixin-compiled-baremetal/dashboards/mimir-rollout-progress.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,7 +1092,7 @@
},
"fill": 1,
"gridPos": {
"h": 5,
"h": 3,
"w": 10,
"x": 0,
"y": 13
Expand Down
2 changes: 1 addition & 1 deletion operations/mimir-mixin-compiled/dashboards/mimir-rollout-progress.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,7 +1092,7 @@
},
"fill": 1,
"gridPos": {
"h": 5,
"h": 3,
"w": 10,
"x": 0,
"y": 13
Expand Down
2 changes: 1 addition & 1 deletion operations/mimir-mixin/dashboards/rollout-progress.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ local filename = 'mimir-rollout-progress.json';
textMode: 'value_and_name',
},
id: 10,
gridPos: { h: 5, w: 10, x: 0, y: 13 },
gridPos: { h: 3, w: 10, x: 0, y: 13 },
},

//
Expand Down