-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm-docs: add migration guides around PodSecurityPolicy and chart 5.0 #5457
Conversation
Describe how to migrate to Kubernetes 1.25 with the helm chart. Describe how to migrate from helm chart 4.x to 5.0. Related to: #5357 Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
forcePSPOnKubernetes124: true | ||
``` | ||
|
||
> **Note**: Warning: this value prevents you from upgrading to Kubernetes version 1.25! Follow the other option before upgrading to Kubernetes 1.25. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forcePSPOnKubernetes124: true | ||
``` | ||
|
||
> **Note**: Warning: this value prevents you from upgrading to Kubernetes version 1.25! Follow the other option before upgrading to Kubernetes 1.25. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> **Note**: Warning: this value prevents you from upgrading to Kubernetes version 1.25! Follow the other option before upgrading to Kubernetes 1.25. | |
> **Note**: Warning: this value prevents you from upgrading to Kubernetes version 1.25. Follow the other option before upgrading to Kubernetes 1.25. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment about note and warning admonitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing. Only a few minor suggestions, but otherwise LGTM
docs/sources/helm-charts/mimir-distributed/migration-guides/migrate-helm-chart-4.x-to-5.0.md
Outdated
Show resolved
Hide resolved
docs/sources/helm-charts/mimir-distributed/migration-guides/migrate-helm-chart-4.x-to-5.0.md
Show resolved
Hide resolved
...sources/helm-charts/mimir-distributed/migration-guides/migrate-to-kubernetes-version-1.25.md
Outdated
Show resolved
Hide resolved
Currently admonition cannot be part of a list, working around that. Signed-off-by: György Krajcsovits <[email protected]>
Co-authored-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
1. If you are on Kubernetes version 1.24 and want to keep using PodSecurityPolicy, then merge the following setting into your custom values file: | ||
```yaml | ||
rbac: | ||
forcePSPOnKubernetes124: true | ||
``` | ||
1. If you have Kubernetes version 1.22 or later and want to upgrade to Kubernetes version 1.25 after this procedure then follow the [Migrate to Kubernetes version 1.25]({{< relref "./migrate-to-kubernetes-version-1.25.md" >}}) guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we give one more option? "Don't do anything", since this is what I expect most users will need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I didn't see this due to auto merge. Yes, I suppose that's valid, just have to formulate carefully.
What this PR does
Describe how to migrate to Kubernetes 1.25 with the helm chart.
Describe how to migrate from helm chart 4.x to 5.0.
Which issue(s) this PR fixes or relates to
Related to: #5357
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]