-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copyblocks: add support for S3-compatible buckets and object storage migration #5486
Conversation
315a6ed
to
3471a88
Compare
…service migration
3471a88
to
fe0091d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, thanks @andyasp!
Co-authored-by: Charles Korn <[email protected]>
Co-authored-by: Charles Korn <[email protected]>
Thanks for keeping me honest with message consistency @charleskorn, those nits were helpful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my feedback @andyasp!
What this PR does
copyblocks currently supports
GCS->GCS
andABS->ABS
server-side copies. This change adds:S3->S3
server-side copy supportso the new support looks like
{ABS, GCS, S3} -> {ABS, GCS, S3}
.Notably
--service
was replaced with--source-service
and--destination-service
, since the services may not be the same.I have not finished testing these changes against real buckets yet, so I'm opening this as a draft.Tests Performed:
The goal of this testing was line coverage by having each service be both a source and a destination in client-side copies and to exercise that the S3 client expects to be passed a correct content length during
Upload
.Which issue(s) this PR fixes or relates to
Fixes: N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]