-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/support aws sdk default credential provider chain #5636
Feat/support aws sdk default credential provider chain #5636
Conversation
a4aa1f1
to
f152918
Compare
Thanks for this PR! I'm confused about why it's necessary though (and why it was added to https://github.com/minio/minio-go/tree/master/pkg/credentials It seems like |
I was also confused and during my research I found a lot of confusion in many issues/PRs and discussions around the topic. My guess is that there is a lot of reinventing the wheel again instead of relying on the default provider chain of the SDK and of course legacy code which doesn't support all of the countless ways how to authenticate against AWS. If I understand it correctly, the minio implementation had no way to use cross account role chaining when the I can say that my use case (which was also the use case of the guy who introduced it in the objstore) is working properly now and I agree with him that relying on a consistent implementation from AWS is better than reimplementing it again and again and again. What do you think? |
That makes sense to me. This is a much quicker way to let people use the auth logic they expect. My only suggestion is a different, slightly more descriptive name for the flag. What do you think about |
Is it okay for you, if I fixup the existing commits? 😊 |
Sure, sounds great. Thanks! |
986d6fd
to
a2d99e2
Compare
I think CI is failing because of whitespace. Can you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: Aljoscha Poertner <[email protected]>
Signed-off-by: Aljoscha Poertner <[email protected]>
…ve-aws-auth-enabled Signed-off-by: Aljoscha Poertner <[email protected]>
….native-aws-auth-enabled Signed-off-by: Aljoscha Poertner <[email protected]>
a2d99e2
to
0757638
Compare
|
What this PR does
This PR allows to use the default credential provider chain of the AWS SDK. It is already part of the used thanos.io/objstore and can now also be enabled for Mimir. The default credential provider chain allows the use of e.g. role chaining using the
./aws/config
or other authentication methods which are not implemented in thanos.io/objstore or Mimir.Example config:
Which issue(s) this PR fixes or relates to
Fixes #5613
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]