Enforce -validation.create-grace-period in the query-frontend when the configured value is 0 #5829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e configured value is 0 Signed-off-by: Marco Pracucci <[email protected]>
3 tasks
pstibrany
approved these changes
Aug 24, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The
-validation.create-grace-periodis always enforced in distributors and ingesters, even when the configured value is 0. However, in the query-frontend we consider the value 0 as "disabled". In this PR I propose to align the behaviour between query-frontend and distributor/ingester.The default value for this setting is 10 minutes, so the behaviour will not change for anyone unless they explicitly set a value of 0. If they explicitly set a value of 0, the distributor/ingester will not ingest any sample with timestamp > real-world time, so in practice there should be no sample in the future to query as well.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]