Distributor write path: put httpgrpc.Errorf() calls at the topmost level#6191

Merged

pstibrany merged 24 commits intomainfrom yuri/handling-errors-new

Oct 6, 2023

+729-488

Commits on Oct 5, 2023

Distributor write path: put httpgrpc.Errorf() calls at the topmost level
duricanikolic
committed
Implementing review findings
duricanikolic
committed
Get rid of replicasNotMatchError and tooManyClustersError
duricanikolic
committed
Remove wrapping from req.WriteRequest() and tenant.TenantID() errors
duricanikolic
committed
Get rid of distrbutorerror.Error interface
duricanikolic
committed
Get rid of push.getHTTPStatusAndMessage()
duricanikolic
committed
Revert validate.CleanAndValidateMetadata signature change
duricanikolic
committed
Make DistributorPushError private
duricanikolic
committed
Rename errors by removing the Error suffix
duricanikolic
committed
Handle service overloaded error correctly
duricanikolic
committed
Fixing review findings
duricanikolic
committed
Ensure errors.As and erros.Is work correctly
duricanikolic
committed
Revert distributor_test.go
duricanikolic
committed
Fix wrong status code 429 instead of 400 in case of TooManyCluster error
duricanikolic
committed
Some refactorings
duricanikolic
committed
Fixing review findings
duricanikolic
committed
Adding TestToHTTPStatus
duricanikolic
committed
Update pkg/distributor/distributorerror/errors.go

duricanikolic
and
colega
committed
Re-declare ReplicasNotMatch and TooManyClusters errors
duricanikolic
committed
Fixing Validation error
duricanikolic
committed
Get rid of most of the methods from validation/errors.go
duricanikolic
committed
Get rid of remaining methods in validation/errors
duricanikolic
committed
Rename all distributorerr constructors
duricanikolic
committed
Fixing review findings
duricanikolic
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Distributor write path: put httpgrpc.Errorf() calls at the topmost level#6191

Commits on Oct 5, 2023

Distributor write path: put httpgrpc.Errorf() calls at the topmost level

Implementing review findings

Get rid of replicasNotMatchError and tooManyClustersError

Remove wrapping from req.WriteRequest() and tenant.TenantID() errors

Get rid of distrbutorerror.Error interface

Get rid of push.getHTTPStatusAndMessage()

Revert validate.CleanAndValidateMetadata signature change

Make DistributorPushError private

Rename errors by removing the Error suffix

Handle service overloaded error correctly

Fixing review findings

Ensure errors.As and erros.Is work correctly

Revert distributor_test.go

Fix wrong status code 429 instead of 400 in case of TooManyCluster error

Some refactorings

Fixing review findings

Adding TestToHTTPStatus

Update pkg/distributor/distributorerror/errors.go

Re-declare ReplicasNotMatch and TooManyClusters errors

Fixing Validation error

Get rid of most of the methods from validation/errors.go

Get rid of remaining methods in validation/errors

Rename all distributorerr constructors

Fixing review findings