Allow ingester.Push() to proceed on soft errors only #6366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Ingester's
ingester.pushSamplesToAppender()
, called byingester.Push()
, appends samples and exemplars to the appender. The former distinguishes between:ingester.Push()
to continue its execution and to ingest all valid samples and exemplars, and to return the first encountered error only at the end, andSo far there was no precise way to determine which error is a soft error. This PR introduces
softError
, an interface that should be implemented by all the errors that shouldn't preventingester.Push()
from going ahead. Only these errors will be considered as soft errors bypushSamplesToAppender()
.Which issue(s) this PR fixes or relates to
Related to #6008
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]