Make ingester errors use mimirpb.ErrorCause #6424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR makes a further step towards the write path error handling improvement. Proto message
mimirpb.ErrorCause
(introduced in #6377) has been extended to cover, together with all possible causes of distributor errors, the causes of ingester errors as well. Its extended definition is:Values
INSTANCE_LIMIT
,SERVICE_UNAVAILABLE
andTSDB_UNAVAILABLE
have been added by this PR.The definition of the
ingesterError
interface, implemented by all ingester-specific errors, has been changed fromto
Its definition is now analogous to the definition of the the
distributorError
interface (introduced in #6377), which is implemented by all distributor-specific errors.Moreover, the
newErrorWithStatus()
constructor has been updated in such a way that in a case of aningesterError
the resultingerrorWithStatus
contains also a status detail of typemimirpb.WriteErrorDetails
corresponding toingesterError.errorCause()
.Which issue(s) this PR fixes or relates to
Part of #6008
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]