Improve signal-to-noise ratio of MimirGossipMembersMismatch warning by replacing it with two new warnings #6508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
force-pushed
the
charleskorn/gossipmembersmismatch
branch
3 times, most recently
from
1c59249 to
574e3fa
Compare
pracucci
approved these changes
Oct 30, 2023
…y replacing it with two new warnings.
charleskorn
force-pushed
the
charleskorn/gossipmembersmismatch
branch
from
9ed474b to
b4a7ef8
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR replaces the MimirGossipMembersMismatch with two new warnings intended to be more reliable.
I will leave this PR as a draft until we've tested these changes at Grafana Labs.
Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]