Ensure that DoNotLogErrors set DoNotLogError header in the HTTP response #6522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Nikolic <[email protected]>
pstibrany
approved these changes
Oct 31, 2023
| @@ -187,3 +189,10 @@ func toHTTPStatus(ctx context.Context, pushErr error, limits *validation.Overrid | |||
|
|
|||
| return http.StatusInternalServerError | |||
| } | |||
|
|
|||
| func addHeaders(w http.ResponseWriter, err error) { | |||
There was a problem hiding this comment.
@ying-jeanne this can be useful in your retry-after work :)
There was a problem hiding this comment.
In fact, after we had a call today I added the addHeaders method to make @ying-jeanne's work easier.
francoposa
pushed a commit
that referenced
this pull request
Oct 31, 2023
…nse (#6522) Signed-off-by: Yuri Nikolic <[email protected]>
francoposa
pushed a commit
that referenced
this pull request
Nov 1, 2023
…nse (#6522) Signed-off-by: Yuri Nikolic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR updates vendored
dskitto revision 52f4e8d. That version ofdskitintroduced typemiddleware.DoNotLogError, representing errors that should not be logged, and a stringserver.DoNotLogErrorHeaderKey, that is used as a header key for marking erroneous HTTP response as non-loggable.This PR removes
mimir'slog.DoNotLogErrorand usesdskit'smiddleware.DoNotLogErrorinstead. Moreover, it ensures that when the push handler receives amiddleware.DoNotLogError, the resulting HTTP response will contain a header with keyhttpgrpc.DoNotLogErrorHeaderKey.Which issue(s) this PR fixes or relates to
Part of #6008
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]