Add unit test to compare histogram_quantile results with and without query sharding #6525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenador
force-pushed
the
zenador/fix-prec-errors-query-sharding-hist-quantile
branch
from
887b4ed to
ca13881
Compare
zenador
force-pushed
the
zenador/fix-prec-errors-query-sharding-hist-quantile
branch
from
ca13881 to
bdd8bfa
Compare
zenador
changed the title
dimitarvdimitrov
deleted the
zenador/fix-prec-errors-query-sharding-hist-quantile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a unit test from #6504 to ensure that the results from
histogram_quantilewith and without query sharding have no significant differences. Before the fix in prometheus/prometheus#13153 was vendored in #6766 , this unit test failed, now it passes.Context: Mimir had a bug that sometimes occurs when summing (or other aggregation) the classic histogram (separate series per bucket) input into
histogram_quantile, when query sharding on the input results in reduced precision which is normally insignificant, but may result in non-monotonicity in the histogram buckets.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]