-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
querier: default to using batch.NewChunkMergeIterator #6814
querier: default to using batch.NewChunkMergeIterator #6814
Conversation
This is a follow-up of 6673 Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, LGTM!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-6814-to-r266 origin/r266
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x e09acc913ef3cd9cdf303728ac6c3b7ff3272ac3
# Push it to GitHub
git push --set-upstream origin backport-6814-to-r266
git switch main
# Remove the local backport branch
git branch -D backport-6814-to-r266 Then, create a pull request where the |
* querier: default to using batch.NewChunkMergeIterator This is a follow-up of 6673 Signed-off-by: Dimitar Dimitrov <[email protected]> * Update CHANGELOG.md Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove configurability of chunkIteratorFunc Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove configurability of chunkIteratorFunc in streaming code Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove unnecessary type declaration Signed-off-by: Dimitar Dimitrov <[email protected]> --------- Signed-off-by: Dimitar Dimitrov <[email protected]> (cherry picked from commit e09acc9)
* querier: default to using batch.NewChunkMergeIterator This is a follow-up of 6673 Signed-off-by: Dimitar Dimitrov <[email protected]> * Update CHANGELOG.md Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove configurability of chunkIteratorFunc Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove configurability of chunkIteratorFunc in streaming code Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove unnecessary type declaration Signed-off-by: Dimitar Dimitrov <[email protected]> --------- Signed-off-by: Dimitar Dimitrov <[email protected]> (cherry picked from commit e09acc9)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-6814-to-r267 origin/r267
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x e09acc913ef3cd9cdf303728ac6c3b7ff3272ac3
# Push it to GitHub
git push --set-upstream origin backport-6814-to-r267
git switch main
# Remove the local backport branch
git branch -D backport-6814-to-r267 Then, create a pull request where the |
* querier: default to using batch.NewChunkMergeIterator This is a follow-up of 6673 Signed-off-by: Dimitar Dimitrov <[email protected]> * Update CHANGELOG.md Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove configurability of chunkIteratorFunc Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove configurability of chunkIteratorFunc in streaming code Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove unnecessary type declaration Signed-off-by: Dimitar Dimitrov <[email protected]> --------- Signed-off-by: Dimitar Dimitrov <[email protected]> (cherry picked from commit e09acc9)
* querier: default to using batch.NewChunkMergeIterator This is a follow-up of 6673 Signed-off-by: Dimitar Dimitrov <[email protected]> * Update CHANGELOG.md Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove configurability of chunkIteratorFunc Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove configurability of chunkIteratorFunc in streaming code Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove unnecessary type declaration Signed-off-by: Dimitar Dimitrov <[email protected]> --------- Signed-off-by: Dimitar Dimitrov <[email protected]> (cherry picked from commit e09acc9) Co-authored-by: Dimitar Dimitrov <[email protected]>
This is a follow-up of #6673