Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): add pure Ingress option instead of the gateway service #6932

Merged
merged 1 commit into from
Dec 18, 2023
Merged

feat(helm): add pure Ingress option instead of the gateway service #6932

merged 1 commit into from
Dec 18, 2023

Conversation

mcanevet
Copy link
Contributor

What this PR does

This PR adds the possibility to use a pure Ingress resource instead of deploying the gateway service when using the mimir-distributed Helm Chart.
It basically mimic a feature available in loki-distributed Helm chart: grafana/helm-charts@c402537

@mcanevet mcanevet requested a review from a team as a code owner December 14, 2023 08:06
@CLAassistant
Copy link

CLAassistant commented Dec 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

dimitarvdimitrov
dimitarvdimitrov reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution. In addition to the comments I've already left, can you add an entry in operations/helm/charts/mimir-distributed/CHANGELOG.md?

@mcanevet mcanevet force-pushed the feat-chart-ingress branch 5 times, most recently from f10fab2 to 431a63d Compare December 15, 2023 12:33
@mcanevet
Copy link
Contributor Author

@dimitarvdimitrov ready for review

dimitarvdimitrov
dimitarvdimitrov reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. I realized that the other ingresses have a different interface and I'm wondering if we should support the same one; specifically the pathPrefix configuration

@mcanevet mcanevet force-pushed the feat-chart-ingress branch 7 times, most recently from 00db207 to 5d8a8e5 Compare December 18, 2023 08:11
@mcanevet
Copy link
Contributor Author

@dimitarvdimitrov ready for review

dimitarvdimitrov
dimitarvdimitrov approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for addressing my comments. I left a few final nitpicks, but other than that this is ready for a merge. Appreciate the contribution :)

@mcanevet
Copy link
Contributor Author

@dimitarvdimitrov 🚀

@dimitarvdimitrov dimitarvdimitrov enabled auto-merge (squash) December 18, 2023 10:43
@dimitarvdimitrov dimitarvdimitrov merged commit 37a69f4 into grafana:main Dec 18, 2023
@mcanevet mcanevet deleted the feat-chart-ingress branch December 18, 2023 11:01
@sentoz sentoz mentioned this pull request Jan 29, 2024
Closed
@z0rc z0rc mentioned this pull request Feb 28, 2024
Open
@rknightion rknightion mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitarvdimitrov dimitarvdimitrov dimitarvdimitrov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcanevet @CLAassistant @dimitarvdimitrov