-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix .metricsUsed in mimirtool analyze rule-file #6953
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field wasn't populated. Fixes #6952 Signed-off-by: Oleg Zaytsev <[email protected]>
Signed-off-by: Oleg Zaytsev <[email protected]>
Signed-off-by: Oleg Zaytsev <[email protected]>
flxbk
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-6953-to-release-2.11 origin/release-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 6a7bee283bfa4113bbf7f3b028c8f1045afe89b9
# Push it to GitHub
git push --set-upstream origin backport-6953-to-release-2.11
git switch main
# Remove the local backport branch
git branch -D backport-6953-to-release-2.11 Then, create a pull request where the |
colega
added a commit
that referenced
this pull request
Dec 18, 2023
* Fix .metricsUsed in mimirtool analyze rule-file This field wasn't populated. Fixes #6952 Signed-off-by: Oleg Zaytsev <[email protected]> * Update CHANGELOG.md Signed-off-by: Oleg Zaytsev <[email protected]> * make license Signed-off-by: Oleg Zaytsev <[email protected]> --------- Signed-off-by: Oleg Zaytsev <[email protected]> (cherry picked from commit 6a7bee2) Signed-off-by: Oleg Zaytsev <[email protected]>
colega
added a commit
that referenced
this pull request
Dec 18, 2023
#6956) * Fix .metricsUsed in mimirtool analyze rule-file (#6953) * Fix .metricsUsed in mimirtool analyze rule-file This field wasn't populated. Fixes #6952 Signed-off-by: Oleg Zaytsev <[email protected]> * Update CHANGELOG.md Signed-off-by: Oleg Zaytsev <[email protected]> * make license Signed-off-by: Oleg Zaytsev <[email protected]> --------- Signed-off-by: Oleg Zaytsev <[email protected]> (cherry picked from commit 6a7bee2) Signed-off-by: Oleg Zaytsev <[email protected]> * Update release notes Signed-off-by: Oleg Zaytsev <[email protected]> --------- Signed-off-by: Oleg Zaytsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field wasn't populated when rule files were analyzed.
Fixes #6952
Signed-off-by: Oleg Zaytsev [email protected]