Chore: remove unused storepb.StoreServer #6958
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
We currently define two identical gRPC services:
storegatewaypb.StoreGatewayServer
andstorepb.StoreServer
. The former was originally defined in Cortex, while the latter was imported from Thanos. In Mimir, we're using onlystoregatewaypb.StoreGatewayServer
and they're identical because they both import the same data types fromstorepb
.storepb.StoreServer
is only used in tests, but there's no good reason to use it. We can simply usestoregatewaypb.StoreGatewayServer
in tests too.In this PR I'm removing
storepb.StoreServer
.Is this a breaking change?
No.
storepb.Store_SeriesServer
andstoregatewaypb.StoreGateway_SeriesServer
interfaces are identical. In fact, our gRPC service implementation isStoreGateway.Series(req *storepb.SeriesRequest, srv storegatewaypb.StoreGateway_SeriesServer)
which uses the correct one.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.