Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove unused storepb.StoreServer #6958

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Dec 18, 2023

What this PR does

We currently define two identical gRPC services: storegatewaypb.StoreGatewayServer and storepb.StoreServer. The former was originally defined in Cortex, while the latter was imported from Thanos. In Mimir, we're using only storegatewaypb.StoreGatewayServer and they're identical because they both import the same data types from storepb.

storepb.StoreServer is only used in tests, but there's no good reason to use it. We can simply use storegatewaypb.StoreGatewayServer in tests too.

In this PR I'm removing storepb.StoreServer.

Is this a breaking change?

No.

storepb.Store_SeriesServer and storegatewaypb.StoreGateway_SeriesServer interfaces are identical. In fact, our gRPC service implementation is StoreGateway.Series(req *storepb.SeriesRequest, srv storegatewaypb.StoreGateway_SeriesServer) which uses the correct one.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
@pracucci pracucci marked this pull request as ready for review December 18, 2023 16:47
@pracucci pracucci requested a review from a team as a code owner December 18, 2023 16:47
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow so all of our tests were technically running against an API which we don’t serve. Neat. I never realized this. LGTM

@colega
Copy link
Contributor

colega commented Dec 18, 2023

Is this a breaking change?
No.

It is a breaking change since we're removing the gRPC service. It doesn't affect us because we're not using it, but I think it still should be mentioned in the CHANGELOG at least as "removed unused thanos.Store grpc service from store-gateway".

Edit: oh, now I see, it's not even being served. Then I said nothing.

@pracucci pracucci merged commit 031381e into main Dec 19, 2023
@pracucci pracucci deleted the chore-remove-storepb-store branch December 19, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants