Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #6922 #7065

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Revert #6922 #7065

merged 1 commit into from
Jan 8, 2024

Conversation

charleskorn
Copy link
Contributor

What this PR does

This PR reverts the merge of #6922.

Some concerns were raised about the approach of #6922 after it was merged.

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • [n/a] Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review January 8, 2024 04:38
@charleskorn charleskorn requested a review from a team as a code owner January 8, 2024 04:38
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the delay in review of the original PR

@charleskorn charleskorn merged commit 71ff092 into main Jan 8, 2024
27 checks passed
@charleskorn charleskorn deleted the charleskorn/revert-6922 branch January 8, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants