-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce sync concurrency in store-gateway by default to reduce disk contention #7136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super convinced we want to update the Mimir default, rather than changing the default config in Jsonnet and Helm. Reason is that this change makes sense if you run on HDD, but not on SSD. Changing this default we're assuming people run on HDD vs SSD, which I'm not sure it's a fair assumption.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline. LGTM, thanks!
👋 @andyasp, is the guidance for this to keep this the same if we're running on SSDs? How can we validate whether this will introduce a regression or not? |
The performance of syncing blocks when running on SSDs should be minimal. In general I don't expect that reducing the concurrency there has a negative effect. One way to verify whether this will have a negative effect is to check how long blocks syncing takes today. Currently measuring sync duration is only possible by looking at logs timestamps from the store-gateway: You want these syncs to not take longer than the sync interval ( |
What this PR does
Follow-up to #5025. Internally we reduced the concurrency even when lazy loading was enabled. This upstreams those changes to the defaults.
Which issue(s) this PR fixes or relates to
Fixes N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.