Add a histogram to observe wait time when kicking off mergeQuerier jobs #7209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chencs
force-pushed
the
casie/add-metric-to-merge-querier
branch
2 times, most recently
from
6c28341 to
c22bf08
Compare
chencs
force-pushed
the
casie/add-metric-to-merge-querier
branch
from
c22bf08 to
a5120cb
Compare
|
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
chencs
force-pushed
the
casie/add-metric-to-merge-querier
branch
from
a5120cb to
cffa15c
Compare
charleskorn
reviewed
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds a native histogram to the mergeQuerier, which observes the time it takes for each upstream querier job to start.
Which issue(s) this PR fixes or relates to
For users running many tenants, it is possible for the mergeQuerier to need to kick off many jobs (code), limited to only
tenant-federation.max-concurrentjobs in parallel. Recording wait time at this point will hopefully give the user insight into whethertenant-federation.max-concurrentshould be tuned.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.