rulestore/local: add support for GetRuleGroup endpoint #7248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narqo
force-pushed
the
ruler-rules-ns-groupname-endpoint
branch
from
e6351f7 to
e7dad33
Compare
56quarters
approved these changes
Jan 31, 2024
Signed-off-by: Vladimir Varankin <[email protected]>
narqo
force-pushed
the
ruler-rules-ns-groupname-endpoint
branch
from
e7dad33 to
68ca053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Add support for the
/config/api/v1/rules/{namespace}/{groupName}in the ruler's "local" store.Note, the changes ended up a bit more involved, than what we anticipated originally. That is, in order for "local" store to follow the
rulestore.RuleStoreinterface, the backend must return the sentinel errors, defined along with the interface. This created a circular dependency between therulestoreandlocalpackages due to how the configs were laid out. The choice the PR made to resolve that, is to move thelocal's config outside the package, close torulestore.Config(see the actual changes).Which issue(s) this PR fixes or relates to
Fixes #6632
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.