Add page for displaying compaction jobs computed from bucket-index. #7381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
jdbaldry
approved these changes
Feb 14, 2024
Co-authored-by: Jack Baldry <[email protected]>
Co-authored-by: Jack Baldry <[email protected]>
aknuds1
reviewed
Feb 14, 2024
jdbaldry
approved these changes
Feb 14, 2024
Co-authored-by: Arve Knudsen <[email protected]>
Co-authored-by: Arve Knudsen <[email protected]>
Congrats, but that's not that difficult in my texts :) |
aknuds1
reviewed
Feb 14, 2024
| <table border="1" cellpadding="5" style="border-collapse: collapse;"> | ||
| <thead> | ||
| <tr> | ||
| <th>Job Number</th> |
There was a problem hiding this comment.
[Nit] Don't we use sentence case also in our UI titles?
Co-authored-by: Arve Knudsen <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds admin page that displays compaction jobs computed from bucket index. This is same output as produced by
tools/compaction-plannertool, without the need to provide all necessary configuration via CLI flags, since compactor already has all the required configuration.Page allows to experiment with different merge shards and split counts, and it can also show which compactor is expected to own (and run) the job based on current state of the ring. (Screenshot was created with only one compactor in the ring)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.