Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: add extra alert options #7442

Conversation

jmichalek132
Copy link
Contributor

What this PR does

Which issue(s) this PR fixes or relates to

Fixes #7435

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@CLAassistant
Copy link

CLAassistant commented Feb 22, 2024

CLA assistant check
All committers have signed the CLA.

chore: add mixing extra alert annotations option

chore: add missing comas
@jmichalek132 jmichalek132 force-pushed the jm-chore-add-mixin-extra-alert-options branch from f3dec09 to f05a35e Compare February 22, 2024 16:29
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR! I think we can streamline this further

@jmichalek132 jmichalek132 marked this pull request as ready for review February 25, 2024 15:36
@jmichalek132 jmichalek132 requested a review from a team as a code owner February 25, 2024 15:36
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot! LGTM with a nitpick on naming

Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dimitarvdimitrov dimitarvdimitrov merged commit fd94abe into grafana:main Feb 28, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mimir mixin add option for inserting extra labels and annotations on alerts
3 participants