Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use smaller requests for TestIngester_inflightPushRequests #7482

Closed
wants to merge 1 commit into from

Conversation

bboreham
Copy link
Contributor

What this PR does

The amount of data required to process for 1 second may be very large - it crashes my desktop which has a very fast processor.
Reducing the target duration to 1/10th of a second allows the test to work with much less resource.

Checklist

  • Tests updated.
  • NA Documentation added.
  • NA CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • NA about-versioning.md updated with experimental features.

@bboreham bboreham requested a review from a team as a code owner February 27, 2024 13:47
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Hopefully it won't make test more flaky on slow machines. 🤞

@bboreham bboreham force-pushed the smaller-inflight-test branch from e984008 to af6a717 Compare April 8, 2024 17:52
@bboreham
Copy link
Contributor Author

bboreham commented Apr 8, 2024

Updated after #7621 which moved some things around.
Update again: trying 250ms since 100ms failed in CI.

Current main:

$ /bin/time go test -count 1 -tags stringlabels -run 'inflightPushRequests' ./pkg/ingester/
ok      github.com/grafana/mimir/pkg/ingester   36.146s
46.19user 6.75system 0:37.24elapsed 142%CPU (0avgtext+0avgdata 17431944maxresident)k
24inputs+2003640outputs (13837major+329096minor)pagefaults 0swaps

This PR:

$ /bin/time go test -tags stringlabels -run 'inflightPushRequests' ./pkg/ingester/
ok      github.com/grafana/mimir/pkg/ingester   (cached)
0.92user 0.43system 0:00.48elapsed 280%CPU (0avgtext+0avgdata 93880maxresident)k

17GB -> 93MB

The amount of data required to process for 1 second may be very large;
1/10th of a second allows the test to work with much less resource.
@bboreham bboreham force-pushed the smaller-inflight-test branch from af6a717 to f14320f Compare April 9, 2024 10:00
@bboreham bboreham marked this pull request as draft July 11, 2024 10:48
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Thank you for your contribution. This pull request has been marked as stale because it has had no activity in the last 150 days. It will be closed in 30 days if there is no further activity. If you need more time, you can add a comment to the PR.

@github-actions github-actions bot added the stale label Jan 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

This pull request has been closed because it has been stale for 30 days with no activity. Feel free to reopen if you want to continue working on this.

@github-actions github-actions bot closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants