Querier: deprecates max-query-into-future #7496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfriedroset
force-pushed
the
deprecate-max-query-into-future
branch
from
64ab698 to
cb1a39a
Compare
|
See slack for the extended context: https://grafana.slack.com/archives/C039863E8P7/p1709045532353379 |
wilfriedroset
force-pushed
the
deprecate-max-query-into-future
branch
from
cb1a39a to
9f66ab8
Compare
56quarters
reviewed
Feb 28, 2024
`max-query-into-future` has been inherited from Cortex when it was running on chunks storage. Its purposes was to avoid errors when data was missing. Since Mimir does not rely on chunks storage anymore, there is no errors nor performance penalty. As such, we can deprecate the setting. Signed-off-by: Wilfried Roset <[email protected]>
wilfriedroset
force-pushed
the
deprecate-max-query-into-future
branch
from
9f66ab8 to
a5c3310
Compare
56quarters
approved these changes
Feb 29, 2024
This was referenced May 6, 2024
7 tasks
|
this doesn't work nicely with |
4 tasks
|
Sorry about the delay @dimitarvdimitrov I was on PTO 😅 |
|
no need to apologise 😄 I was just leaving a trace in the PR |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
max-query-into-futurehas been inherited from Cortex when it was running on chunks storage. Its purposes was to avoid errors when data was missing.Since Mimir does not rely on chunks storage anymore, there is no errors nor performance penalty. As such, we can deprecate the setting.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.