-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mixin: make range interval configurable in alerts #7591
mixin: make range interval configurable in alerts #7591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the approach looks good 👍
As discussed, the range selector is now dynamic only for alerts with the default value under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the change. There is one more query I could find in autoscaling.libsonnet which uses a range of 5m. Can you take care of that too?
label_replace(rate(keda_scaler_errors[5m]), "namespace", "$1", "exported_namespace", "(.*)") |
fixed. |
I also noticed that a lot of recording rules have range interval hardcoded and don't use |
Test failure seems to be unrelated to my changes to the mixin. |
yep, there's already a filed issue for that test #5471 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you :)
would actually be nice to add a changelog entry. My suggestion was something like
|
724036d
to
f688191
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lovely, thank you!
Head branch was pushed to by a user without write access
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #7546
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.