distributor, ruler: expect METHOD_NOT_ALLOWED from pusher #7645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narqo
force-pushed
the
distributor-ingester-dont-push-grpc
branch
from
ef1e123 to
b19b8aa
Compare
pracucci
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
LGTM
Can you do the mapping in mapPushErrorToErrorWithHTTPOrGRPCStatus() and mapPushErrorToErrorWithStatus() too, please? It's not required today, but METHOD_NOT_ALLOWED is a generic error we may reuse in the future for other reasons and it should be mapped consistently with other ingester errors.
Signed-off-by: Vladimir Varankin <[email protected]>
narqo
force-pushed
the
distributor-ingester-dont-push-grpc
branch
from
b19b8aa to
0ec1cfb
Compare
Signed-off-by: Vladimir Varankin <[email protected]>
narqo
force-pushed
the
distributor-ingester-dont-push-grpc
branch
from
0ec1cfb to
bf9a19d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Following #7618, after a follow-up discussion, it makes sense to have an explicit mapping from ingester's
METHOD_NOT_ALLOWEDto an HTTP 5xx.cc @pstibrany @pracucci
Which issue(s) this PR fixes or relates to
n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.