Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query-frontend] Close response body in request handler (#7654) #7660

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

flxbk
Copy link
Contributor

@flxbk flxbk commented Mar 19, 2024

  • [query-frontend] close response body in request handler

(cherry picked from commit eaef377)

What this PR does

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@flxbk flxbk marked this pull request as ready for review March 19, 2024 11:26
@flxbk flxbk requested a review from a team as a code owner March 19, 2024 11:26
CHANGELOG.md Outdated
@@ -4,13 +4,15 @@

### Grafana Mimir

* [CHANGE] Querier: the CLI flag `-querier.minimize-ingester-requests` has been moved from "experimental" to "advanced". #7638
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this slipped through while merging conflicts, thanks!

@flxbk flxbk force-pushed the backport-7654-to-r282 branch from 7ca222c to 4ee86c9 Compare March 19, 2024 11:40
@flxbk flxbk enabled auto-merge (squash) March 19, 2024 11:45
@flxbk flxbk merged commit 12c9f3b into r282 Mar 19, 2024
28 checks passed
@flxbk flxbk deleted the backport-7654-to-r282 branch March 19, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants